fix: only build verb schema for non-nil refs #1591
Conversation
wesbillman
requested review from
a team and
matt2e
and removed request for
a team
| if decl, ok := sch.Resolve(n).Get(); ok { | ||
| *verbString += decl.String() + "\n\n" | ||
| err := visitNode(sch, decl, verbString) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
@alecthomas this change sort of undoes the change that was made here: 3c91886#diff-cf10aad402fc38d803d69ee88de91fa8b7f27d33ea52e2dc67ebb6749dfe61afR47-R50 so I wanted to call it out.
Maybe there's a better approach we can use here, but wanted to fix the broken console until then.
There was a problem hiding this comment.
This looks identical to me, just reordered, or am I missing something?
There was a problem hiding this comment.
yeah it's very similar. The difference is that this one doesn't error if the decl cannot be resolved, it just skips it. This was happening for Body in the HttpRequest<Body> data types. Since Body isn't a ref that it can find.
There was a problem hiding this comment.
So instead of:
return fmt.Errorf("failed to resolve %s", n)it just moves on to the next Ref
There was a problem hiding this comment.
Aaah I see, makes sense
Fixes #1578
We might want more protection around refs not being found, but I wasn't sure how to make this allow for
TypeParametersand also keep that protection. This fix gets things working again, but we might want to revisit this as well.